tests/codegen-llvm: Make size argument to llvm.lifetime.{start,end} optional in c-variadic-lifetime test #146583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptional in c-variadic-lifetime test This parameter was removed in LLVM 22 and most tests are updated to make it optional, but apparently this one wasn't updated yet. Signed-off-by: Jens Reidel <[email protected]>
rustbot
added
S-waiting-on-review
|
This test is just new, and I adapted the matching from some other place. It was added in #144549. |
Ah, right, that explains it. I didn't really bother checking why this happened, I just wanted my tests against LLVM main to pass :) |
nikic
added
the
llvm-main
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
This looks the same as #146480 which is merged? |
Looks like it. I'll close this PR, didn't realize there was already a pending PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter was removed in LLVM 22 and most tests are updated to make it optional, but apparently this one wasn't updated yet.
r? @nikic